16 Commits (98d57a82b4c0c5802c55dbc8390223dd3ed8cdfc)

Author	SHA1	Message	Date
Mike Cao	98d57a82b4	$_GET should not be overwritten.	12 years ago
Mike Cao	440cca5901	Minor code changes	12 years ago
kafene	96c25ff1f3	Fixed never-returned proxy IP	12 years ago
kafene	5270c6b23a	a few enhancements to request.php ... - added "secure" parameter to avoid boilerplate "if https && https != 'off'" - added "accept" parameter containing request's HTTP_ACCEPT value if any - Changed IP to always be REMOTE_ADDR, as this is the only "real" ip of the request. - Added 'proxy' parameter containing any proxy-forwarded IP - Changed getIpAddress to getProxyIpAddress - renamed $vars to $forwarded to be a bit more explicit - Removed REMOTE_ADDR from proxy forwarded addresses to detect - change explode() to sscanf, will explain this later. - added flags to the filter_var, will also explain later - added getMethodOverride function to detect request method overrides I did some research because I was wondering why it would be necessary to check for a comma, and apparently some proxies do send a comma separated list of IP addresses, with the originating client IP as the first one. It had a feeling that instead of using explode() where the first value would always be returned, there must be another way to get the first value of a token-delimited string, or just the whole string if there was no token, and I bumped in to my old friend sscanf. So the loop is now 3 levels. As far as the flags, see: http://php.net/manual/en/filter.filters.flags.php These ensure that any IP detected is not a useless IP behind a remote NAT. For example, a corporate proxy might send HTTP_X_FORWARDED_FOR using the internal IP of the user, but the only useful IP in this case is that of the proxy, which PHP gets as REMOTE_ADDR. If you find any of these changes acceptable but don't want to merge them all, do feel free to implement whichever you like. I was thinking of adding a getRequestMethod() function to check for `$_SERVER['HTTP_X_HTTP_METHOD_OVERRIDE']` or `$_POST['_method']` to allow clients to negotiate PUT/DELETE requests, but personally I am indifferent to these, as I never use methods beyond GET and POST (I'm not very RESTful I guess), and it's not really my place to be writing an implementation of either. Other frameworks seem to just overwrite the method parameter so that it appears to be the overridden one.	12 years ago
Mike Cao	f2bd6f4e02	Allow framework to be reinitialized	12 years ago
Mike Cao	cec890c585	Code cleanup	12 years ago
Mike Cao	c6fdc21bd8	Fixed PHP notice error	12 years ago
Mike Cao	d081879379	Parameters should be URL decoded.	12 years ago
Mike Cao	4f48bd36be	Fixed problem regexes in optional parameters	12 years ago
Mike Cao	257d0650d3	Added support for optional route parameters	12 years ago
Mike Cao	37c50c5eee	Added method to get real IP address	12 years ago
Mike Cao	5f98e1e06c	Fixed issue with setting status codes.	13 years ago
Mike Cao	830088733d	Fixed PHP notices	13 years ago
Mike Cao	b70f831c0e	Added new Collection class, updated documentation	13 years ago
Mike Cao	5d789ceb2e	More refactoring, updated documenation	13 years ago
Mike Cao	e2f1dc99bb	Major refactoring, implemented namespaces	13 years ago