From dddd6ab72a7e6779a07533b17f1962c624746f8f Mon Sep 17 00:00:00 2001 From: fadrian06 Date: Thu, 13 Aug 2026 23:55:15 -0400 Subject: [PATCH 1/8] update the coding standards to PSR12 --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 4b1af6d..3f60042 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -9,7 +9,7 @@ Flight aims to be simple and fast. Anything that compromises either of those two * **Dependencies** - We strive to be dependency free in Flight. Yes even polyfills, yes even `Interface` only repos like `psr/container`. The fewer dependencies, the fewer your exposed attack vectors. -* **Coding Standards** - We use PSR1 coding standards enforced by PHPCS. Some standards that either need additional configuration or need to be manually done are: +* **Coding Standards** - We use PSR12 coding standards enforced by PHPCS. Some standards that either need additional configuration or need to be manually done are: * PHPStan is at level 6. * `===` instead of truthy or falsey statements like `==` or `!is_array()`. From 412faa120f62d01b36628eed5e6171abc0c55b10 Mon Sep 17 00:00:00 2001 From: fadrian06 Date: Thu, 13 Aug 2026 23:55:44 -0400 Subject: [PATCH 2/8] adjust the php versions in the tests --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 3f60042..e6acc53 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -17,7 +17,7 @@ Flight aims to be simple and fast. Anything that compromises either of those two * **Core functionality vs Plugin** - Have a conversation with us in the [chatroom](https://matrix.to/#/!cTfwPXhpkTXPXwVmxY:matrix.org?via=matrix.org&via=leitstelle511.net&via=integrations.ems.host) to know if your idea is worth makes sense in the framework or in a plugin. -* **Testing** - Until automated testing is put into place, any PRs must pass unit testing in PHP 7.4 and PHP 8.2+. Additionally you need to run `composer test-server` and `composer test-server-v2` and ensure all the header links work correctly. +* **Testing** - Until automated testing is put into place, any PRs must pass unit testing in PHP 7.4 to PHP 8.5+. Additionally you need to run `composer test-server` and `composer test-server-v2` and ensure all the header links work correctly. #### **Did you find a bug?** From fa08cd68ff564997bdc030aefde90a610acae76e Mon Sep 17 00:00:00 2001 From: fadrian06 Date: Thu, 13 Aug 2026 23:56:38 -0400 Subject: [PATCH 3/8] remove restriction about the ! (NOT) operator --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index e6acc53..3bf7cbc 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -11,7 +11,7 @@ Flight aims to be simple and fast. Anything that compromises either of those two * **Coding Standards** - We use PSR12 coding standards enforced by PHPCS. Some standards that either need additional configuration or need to be manually done are: * PHPStan is at level 6. - * `===` instead of truthy or falsey statements like `==` or `!is_array()`. + * `===` instead of truthy or falsey statements like `==`. * **PHP 7.4 Focused** - We do not make PHP 8+ focused enhancements on the framework as the focus is maintaining PHP 7.4. From a86e4078ca247fe6234bbb0264770f32ecae71a0 Mon Sep 17 00:00:00 2001 From: fadrian06 Date: Thu, 13 Aug 2026 23:57:20 -0400 Subject: [PATCH 4/8] improve the redaction of CONTRIBUTING.md about security vulnerabilities --- CONTRIBUTING.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 3bf7cbc..6152b09 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -12,7 +12,7 @@ Flight aims to be simple and fast. Anything that compromises either of those two * **Coding Standards** - We use PSR12 coding standards enforced by PHPCS. Some standards that either need additional configuration or need to be manually done are: * PHPStan is at level 6. * `===` instead of truthy or falsey statements like `==`. - + * **PHP 7.4 Focused** - We do not make PHP 8+ focused enhancements on the framework as the focus is maintaining PHP 7.4. * **Core functionality vs Plugin** - Have a conversation with us in the [chatroom](https://matrix.to/#/!cTfwPXhpkTXPXwVmxY:matrix.org?via=matrix.org&via=leitstelle511.net&via=integrations.ems.host) to know if your idea is worth makes sense in the framework or in a plugin. @@ -21,7 +21,7 @@ Flight aims to be simple and fast. Anything that compromises either of those two #### **Did you find a bug?** -* **Do not open up a GitHub issue if the bug is a security vulnerability**. Instead contact maintainers directly via email to safely pass in the information related to the security vuln. +* **Do not open up a GitHub issue if the bug is a security vulnerability**. Instead contact maintainers directly via email to safely pass in the information related to the security vulnerability. * **Ensure the bug was not already reported** by searching on GitHub under [Issues](https://github.com/flightphp/core/issues). From b464dc18f40299c8d47541966738fddde39ebc27 Mon Sep 17 00:00:00 2001 From: fadrian06 Date: Fri, 14 Aug 2026 00:58:03 -0400 Subject: [PATCH 5/8] PSR12 -> PSR-12 Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 6152b09..d6d9f65 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -9,7 +9,7 @@ Flight aims to be simple and fast. Anything that compromises either of those two * **Dependencies** - We strive to be dependency free in Flight. Yes even polyfills, yes even `Interface` only repos like `psr/container`. The fewer dependencies, the fewer your exposed attack vectors. -* **Coding Standards** - We use PSR12 coding standards enforced by PHPCS. Some standards that either need additional configuration or need to be manually done are: +* **Coding Standards** - We use PSR-12 coding standards enforced by PHPCS. Some standards that either need additional configuration or need to be manually done are: * PHPStan is at level 6. * `===` instead of truthy or falsey statements like `==`. From ae0440eb8000e8d8a407270b20e1431a20f8fd50 Mon Sep 17 00:00:00 2001 From: fadrian06 Date: Fri, 14 Aug 2026 01:00:01 -0400 Subject: [PATCH 6/8] remove "Until automated testing is put into place" CI Tests were implemented and running successfully Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index d6d9f65..956c789 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -17,7 +17,7 @@ Flight aims to be simple and fast. Anything that compromises either of those two * **Core functionality vs Plugin** - Have a conversation with us in the [chatroom](https://matrix.to/#/!cTfwPXhpkTXPXwVmxY:matrix.org?via=matrix.org&via=leitstelle511.net&via=integrations.ems.host) to know if your idea is worth makes sense in the framework or in a plugin. -* **Testing** - Until automated testing is put into place, any PRs must pass unit testing in PHP 7.4 to PHP 8.5+. Additionally you need to run `composer test-server` and `composer test-server-v2` and ensure all the header links work correctly. +* **Testing** - PRs must pass unit tests on PHP 7.4 through PHP 8.5+. Additionally you need to run `composer test-server` and `composer test-server-v2` and ensure all the header links work correctly. #### **Did you find a bug?** From d566684b7e1ff9353848eeb635db38d4e3fd57d4 Mon Sep 17 00:00:00 2001 From: fadrian06 Date: Fri, 14 Aug 2026 01:01:22 -0400 Subject: [PATCH 7/8] improve redaction about reporting security vulnerabilities Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 956c789..99b106c 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -21,7 +21,7 @@ Flight aims to be simple and fast. Anything that compromises either of those two #### **Did you find a bug?** -* **Do not open up a GitHub issue if the bug is a security vulnerability**. Instead contact maintainers directly via email to safely pass in the information related to the security vulnerability. +* **Do not open up a GitHub issue if the bug is a security vulnerability**. Instead contact maintainers directly via email to safely share details about the security vulnerability. * **Ensure the bug was not already reported** by searching on GitHub under [Issues](https://github.com/flightphp/core/issues). From cc0116928167a7accc9948eff4a660caeaeb13f9 Mon Sep 17 00:00:00 2001 From: fadrian06 Date: Fri, 14 Aug 2026 01:01:46 -0400 Subject: [PATCH 8/8] falsey -> falsy Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 99b106c..1004dd2 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -11,7 +11,7 @@ Flight aims to be simple and fast. Anything that compromises either of those two * **Coding Standards** - We use PSR-12 coding standards enforced by PHPCS. Some standards that either need additional configuration or need to be manually done are: * PHPStan is at level 6. - * `===` instead of truthy or falsey statements like `==`. + * `===` instead of truthy or falsy statements like `==`. * **PHP 7.4 Focused** - We do not make PHP 8+ focused enhancements on the framework as the focus is maintaining PHP 7.4.