From f7580a8b526010712156ec67caa5f8f7324f5892 Mon Sep 17 00:00:00 2001
From: Thibaut Courouble <thibaut@me.com>
Date: Sun, 16 Jul 2017 17:05:19 -0400
Subject: [PATCH] Download images by default

Rel: #633
---
 lib/docs/core/scraper.rb        | 1 +
 lib/docs/filters/core/images.rb | 2 ++
 lib/docs/scrapers/mdn/mdn.rb    | 2 +-
 3 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/lib/docs/core/scraper.rb b/lib/docs/core/scraper.rb
index 044f0835..34f1f55b 100644
--- a/lib/docs/core/scraper.rb
+++ b/lib/docs/core/scraper.rb
@@ -42,6 +42,7 @@ module Docs
     self.text_filters = FilterStack.new
 
     html_filters.push 'apply_base_url', 'container', 'clean_html', 'normalize_urls', 'internal_urls', 'normalize_paths'
+    text_filters.push 'images' # ensure the images filter runs after all html filters
     text_filters.push 'inner_html', 'clean_text', 'attribution'
 
     def initialize
diff --git a/lib/docs/filters/core/images.rb b/lib/docs/filters/core/images.rb
index 9c449639..d88b65cd 100644
--- a/lib/docs/filters/core/images.rb
+++ b/lib/docs/filters/core/images.rb
@@ -10,6 +10,8 @@ module Docs
     end
 
     def call
+      return doc if context[:download_images] == false
+
       @@cache ||= {}
 
       doc.css('img[src]').each do |node|
diff --git a/lib/docs/scrapers/mdn/mdn.rb b/lib/docs/scrapers/mdn/mdn.rb
index ae7a8533..1c01ccd7 100644
--- a/lib/docs/scrapers/mdn/mdn.rb
+++ b/lib/docs/scrapers/mdn/mdn.rb
@@ -6,7 +6,7 @@ module Docs
     params[:raw] = 1
     params[:macros] = 1
 
-    html_filters.push 'mdn/clean_html', 'images'
+    html_filters.push 'mdn/clean_html'
     text_filters.insert_before 'attribution', 'mdn/contribute_link'
 
     options[:trailing_slash] = false