From f208e4d45bf2f65e54dc3181c157f7edfcba4d75 Mon Sep 17 00:00:00 2001
From: Iaian Weber <iweber@mystrength.com>
Date: Tue, 9 Oct 2018 15:02:15 -0600
Subject: [PATCH] Fixing dark mode external link display

- Only apply %external-link in a:after
---
 assets/stylesheets/components/_page.scss    | 4 +++-
 assets/stylesheets/components/_sidebar.scss | 6 ++++--
 2 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/assets/stylesheets/components/_page.scss b/assets/stylesheets/components/_page.scss
index 60a970b9..769461a8 100644
--- a/assets/stylesheets/components/_page.scss
+++ b/assets/stylesheets/components/_page.scss
@@ -11,7 +11,9 @@
   > h1 { @extend ._lined-heading; }
   > h1:first-child { margin-top: 0; }
 
-  a[href^="http:"], a[href^="https:"] { @extend %external-link; }
+  a[href^="http:"], a[href^="https:"] {
+    &:after { @extend %external-link; }
+  }
 
   a:not([href]) {
     color: inherit;
diff --git a/assets/stylesheets/components/_sidebar.scss b/assets/stylesheets/components/_sidebar.scss
index 8813f92d..f33414cb 100644
--- a/assets/stylesheets/components/_sidebar.scss
+++ b/assets/stylesheets/components/_sidebar.scss
@@ -362,8 +362,10 @@
   padding: .75rem 0;
   font-size: .8125rem;
   text-align: center;
-  @extend %external-link;
 
-  &:after { visibility: hidden; }
+  &:after {
+    @extend %external-link;
+    visibility: hidden;
+  }
   &:hover:after { visibility: visible; }
 }