From e5fcde09f9fac77a98ad21d14f8c875ad30013cc Mon Sep 17 00:00:00 2001
From: Simon Legner <Simon.Legner@gmail.com>
Date: Sat, 6 Jan 2024 16:18:36 +0100
Subject: [PATCH] Sanity-check decaffeinate the rest

---
 assets/javascripts/application.js             |  7 ------
 assets/javascripts/debug.js                   | 12 ----------
 assets/javascripts/lib/favicon.js             |  8 -------
 assets/javascripts/lib/license.js             |  2 --
 assets/javascripts/lib/local_storage_store.js |  7 ------
 assets/javascripts/models/doc.js              |  8 -------
 assets/javascripts/models/model.js            |  2 --
 assets/javascripts/models/type.js             |  7 ------
 assets/javascripts/templates/error_tmpl.js    |  9 -------
 assets/javascripts/templates/notice_tmpl.js   |  7 ------
 assets/javascripts/templates/notif_tmpl.js    | 12 ++--------
 .../templates/pages/news_tmpl.js.erb          |  5 ----
 .../templates/pages/offline_tmpl.js           |  7 ------
 .../templates/pages/settings_tmpl.js          |  7 ------
 .../javascripts/templates/pages/type_tmpl.js  | 24 +++++++------------
 assets/javascripts/templates/path_tmpl.js     |  8 -------
 assets/javascripts/templates/sidebar_tmpl.js  |  8 -------
 assets/javascripts/templates/tip_tmpl.js      |  7 ------
 .../javascripts/views/content/static_page.js  |  8 -------
 19 files changed, 11 insertions(+), 144 deletions(-)

diff --git a/assets/javascripts/application.js b/assets/javascripts/application.js
index 81995783..0bfa4568 100644
--- a/assets/javascripts/application.js
+++ b/assets/javascripts/application.js
@@ -1,10 +1,3 @@
-// TODO: This file was created by bulk-decaffeinate.
-// Sanity-check the conversion and remove this comment.
-/*
- * decaffeinate suggestions:
- * DS102: Remove unnecessary code created because of implicit returns
- * Full docs: https://github.com/decaffeinate/decaffeinate/blob/main/docs/suggestions.md
- */
 //= require_tree ./vendor
 
 //= require lib/license
diff --git a/assets/javascripts/debug.js b/assets/javascripts/debug.js
index d91a688f..4539445e 100644
--- a/assets/javascripts/debug.js
+++ b/assets/javascripts/debug.js
@@ -1,15 +1,3 @@
-// TODO: This file was created by bulk-decaffeinate.
-// Sanity-check the conversion and remove this comment.
-/*
- * decaffeinate suggestions:
- * DS102: Remove unnecessary code created because of implicit returns
- * DS203: Remove `|| {}` from converted for-own loops
- * DS207: Consider shorter variations of null checks
- * DS208: Avoid top-level this
- * DS209: Avoid top-level return
- * Full docs: https://github.com/decaffeinate/decaffeinate/blob/main/docs/suggestions.md
- */
-
 //
 // App
 //
diff --git a/assets/javascripts/lib/favicon.js b/assets/javascripts/lib/favicon.js
index b4a7a43b..c4be8d74 100644
--- a/assets/javascripts/lib/favicon.js
+++ b/assets/javascripts/lib/favicon.js
@@ -1,11 +1,3 @@
-// TODO: This file was created by bulk-decaffeinate.
-// Sanity-check the conversion and remove this comment.
-/*
- * decaffeinate suggestions:
- * DS102: Remove unnecessary code created because of implicit returns
- * DS208: Avoid top-level this
- * Full docs: https://github.com/decaffeinate/decaffeinate/blob/main/docs/suggestions.md
- */
 let defaultUrl = null;
 let currentSlug = null;
 
diff --git a/assets/javascripts/lib/license.js b/assets/javascripts/lib/license.js
index 7379e3a8..883885a3 100644
--- a/assets/javascripts/lib/license.js
+++ b/assets/javascripts/lib/license.js
@@ -1,5 +1,3 @@
-// TODO: This file was created by bulk-decaffeinate.
-// Sanity-check the conversion and remove this comment.
 /*
  * Copyright 2013-2023 Thibaut Courouble and other contributors
  *
diff --git a/assets/javascripts/lib/local_storage_store.js b/assets/javascripts/lib/local_storage_store.js
index 085777fa..25a4ee90 100644
--- a/assets/javascripts/lib/local_storage_store.js
+++ b/assets/javascripts/lib/local_storage_store.js
@@ -1,10 +1,3 @@
-// TODO: This file was created by bulk-decaffeinate.
-// Sanity-check the conversion and remove this comment.
-/*
- * decaffeinate suggestions:
- * DS102: Remove unnecessary code created because of implicit returns
- * Full docs: https://github.com/decaffeinate/decaffeinate/blob/main/docs/suggestions.md
- */
 this.LocalStorageStore = class LocalStorageStore {
   get(key) {
     try {
diff --git a/assets/javascripts/models/doc.js b/assets/javascripts/models/doc.js
index f49ce49b..53d573cd 100644
--- a/assets/javascripts/models/doc.js
+++ b/assets/javascripts/models/doc.js
@@ -1,11 +1,3 @@
-// TODO: This file was created by bulk-decaffeinate.
-// Sanity-check the conversion and remove this comment.
-/*
- * decaffeinate suggestions:
- * DS102: Remove unnecessary code created because of implicit returns
- * DS207: Consider shorter variations of null checks
- * Full docs: https://github.com/decaffeinate/decaffeinate/blob/main/docs/suggestions.md
- */
 app.models.Doc = class Doc extends app.Model {
   // Attributes: name, slug, type, version, release, db_size, mtime, links
 
diff --git a/assets/javascripts/models/model.js b/assets/javascripts/models/model.js
index 9d8885d9..def06e55 100644
--- a/assets/javascripts/models/model.js
+++ b/assets/javascripts/models/model.js
@@ -1,5 +1,3 @@
-// TODO: This file was created by bulk-decaffeinate.
-// Sanity-check the conversion and remove this comment.
 app.Model = class Model {
   constructor(attributes) {
     for (var key in attributes) {
diff --git a/assets/javascripts/models/type.js b/assets/javascripts/models/type.js
index 178e6a8b..bc264ac1 100644
--- a/assets/javascripts/models/type.js
+++ b/assets/javascripts/models/type.js
@@ -1,10 +1,3 @@
-// TODO: This file was created by bulk-decaffeinate.
-// Sanity-check the conversion and remove this comment.
-/*
- * decaffeinate suggestions:
- * DS102: Remove unnecessary code created because of implicit returns
- * Full docs: https://github.com/decaffeinate/decaffeinate/blob/main/docs/suggestions.md
- */
 app.models.Type = class Type extends app.Model {
   // Attributes: name, slug, count
 
diff --git a/assets/javascripts/templates/error_tmpl.js b/assets/javascripts/templates/error_tmpl.js
index 0dbd9b52..c047d46e 100644
--- a/assets/javascripts/templates/error_tmpl.js
+++ b/assets/javascripts/templates/error_tmpl.js
@@ -1,12 +1,3 @@
-// TODO: This file was created by bulk-decaffeinate.
-// Sanity-check the conversion and remove this comment.
-/*
- * decaffeinate suggestions:
- * DS102: Remove unnecessary code created because of implicit returns
- * DS205: Consider reworking code to avoid use of IIFEs
- * DS207: Consider shorter variations of null checks
- * Full docs: https://github.com/decaffeinate/decaffeinate/blob/main/docs/suggestions.md
- */
 const error = function (title, text, links) {
   if (text == null) {
     text = "";
diff --git a/assets/javascripts/templates/notice_tmpl.js b/assets/javascripts/templates/notice_tmpl.js
index 7e168d3e..49793eb5 100644
--- a/assets/javascripts/templates/notice_tmpl.js
+++ b/assets/javascripts/templates/notice_tmpl.js
@@ -1,10 +1,3 @@
-// TODO: This file was created by bulk-decaffeinate.
-// Sanity-check the conversion and remove this comment.
-/*
- * decaffeinate suggestions:
- * DS102: Remove unnecessary code created because of implicit returns
- * Full docs: https://github.com/decaffeinate/decaffeinate/blob/main/docs/suggestions.md
- */
 const notice = (text) => `<p class="_notice-text">${text}</p>`;
 
 app.templates.singleDocNotice = (doc) =>
diff --git a/assets/javascripts/templates/notif_tmpl.js b/assets/javascripts/templates/notif_tmpl.js
index 4d743a85..f24c3c11 100644
--- a/assets/javascripts/templates/notif_tmpl.js
+++ b/assets/javascripts/templates/notif_tmpl.js
@@ -1,11 +1,3 @@
-// TODO: This file was created by bulk-decaffeinate.
-// Sanity-check the conversion and remove this comment.
-/*
- * decaffeinate suggestions:
- * DS101: Remove unnecessary use of Array.from
- * DS102: Remove unnecessary code created because of implicit returns
- * Full docs: https://github.com/decaffeinate/decaffeinate/blob/main/docs/suggestions.md
- */
 const notif = function (title, html) {
   html = html.replace(/<a /g, '<a class="_notif-link" ');
   return ` <h5 class="_notif-title">${title}</h5>
@@ -70,7 +62,7 @@ app.templates.notifUpdates = function (docs, disabledDocs) {
   if (docs.length > 0) {
     html += '<div class="_news-row">';
     html += '<ul class="_notif-list">';
-    for (doc of Array.from(docs)) {
+    for (doc of docs) {
       html += `<li>${doc.name}`;
       if (doc.release) {
         html += ` <code>&rarr;</code> ${doc.release}`;
@@ -82,7 +74,7 @@ app.templates.notifUpdates = function (docs, disabledDocs) {
   if (disabledDocs.length > 0) {
     html += '<div class="_news-row"><p class="_news-title">Disabled:';
     html += '<ul class="_notif-list">';
-    for (doc of Array.from(disabledDocs)) {
+    for (doc of disabledDocs) {
       html += `<li>${doc.name}`;
       if (doc.release) {
         html += ` <code>&rarr;</code> ${doc.release}`;
diff --git a/assets/javascripts/templates/pages/news_tmpl.js.erb b/assets/javascripts/templates/pages/news_tmpl.js.erb
index 18f829e2..72f4b1dd 100644
--- a/assets/javascripts/templates/pages/news_tmpl.js.erb
+++ b/assets/javascripts/templates/pages/news_tmpl.js.erb
@@ -1,8 +1,3 @@
-/*
- * decaffeinate suggestions:
- * DS102: Remove unnecessary code created because of implicit returns
- * Full docs: https://github.com/decaffeinate/decaffeinate/blob/main/docs/suggestions.md
- */
 //= depend_on news.json
 
 app.templates.newsPage = () => ` <h1 class="_lined-heading">Changelog</h1>
diff --git a/assets/javascripts/templates/pages/offline_tmpl.js b/assets/javascripts/templates/pages/offline_tmpl.js
index de24236a..ad467531 100644
--- a/assets/javascripts/templates/pages/offline_tmpl.js
+++ b/assets/javascripts/templates/pages/offline_tmpl.js
@@ -1,10 +1,3 @@
-// TODO: This file was created by bulk-decaffeinate.
-// Sanity-check the conversion and remove this comment.
-/*
- * decaffeinate suggestions:
- * DS102: Remove unnecessary code created because of implicit returns
- * Full docs: https://github.com/decaffeinate/decaffeinate/blob/main/docs/suggestions.md
- */
 app.templates.offlinePage = (docs) => `\
 <h1 class="_lined-heading">Offline Documentation</h1>
 
diff --git a/assets/javascripts/templates/pages/settings_tmpl.js b/assets/javascripts/templates/pages/settings_tmpl.js
index da108a4b..1fae3975 100644
--- a/assets/javascripts/templates/pages/settings_tmpl.js
+++ b/assets/javascripts/templates/pages/settings_tmpl.js
@@ -1,10 +1,3 @@
-// TODO: This file was created by bulk-decaffeinate.
-// Sanity-check the conversion and remove this comment.
-/*
- * decaffeinate suggestions:
- * DS102: Remove unnecessary code created because of implicit returns
- * Full docs: https://github.com/decaffeinate/decaffeinate/blob/main/docs/suggestions.md
- */
 const themeOption = ({ label, value }, settings) => `\
 <label class="_settings-label _theme-label">
   <input type="radio" name="theme" value="${value}"${
diff --git a/assets/javascripts/templates/pages/type_tmpl.js b/assets/javascripts/templates/pages/type_tmpl.js
index 87697cd4..8e072332 100644
--- a/assets/javascripts/templates/pages/type_tmpl.js
+++ b/assets/javascripts/templates/pages/type_tmpl.js
@@ -1,17 +1,11 @@
-// TODO: This file was created by bulk-decaffeinate.
-// Sanity-check the conversion and remove this comment.
-/*
- * decaffeinate suggestions:
- * DS102: Remove unnecessary code created because of implicit returns
- * Full docs: https://github.com/decaffeinate/decaffeinate/blob/main/docs/suggestions.md
- */
-app.templates.typePage = (type) => ` <h1>${type.doc.fullName} / ${
-  type.name
-}</h1>
+app.templates.typePage = (type) => {
+  return ` <h1>${type.doc.fullName} / ${type.name}</h1>
 <ul class="_entry-list">${app.templates.render(
-  "typePageEntry",
-  type.entries(),
-)}</ul> `;
+    "typePageEntry",
+    type.entries(),
+  )}</ul> `;
+};
 
-app.templates.typePageEntry = (entry) =>
-  `<li><a href="${entry.fullPath()}">${$.escape(entry.name)}</a></li>`;
+app.templates.typePageEntry = (entry) => {
+  return `<li><a href="${entry.fullPath()}">${$.escape(entry.name)}</a></li>`;
+};
diff --git a/assets/javascripts/templates/path_tmpl.js b/assets/javascripts/templates/path_tmpl.js
index ba17d407..9d02c042 100644
--- a/assets/javascripts/templates/path_tmpl.js
+++ b/assets/javascripts/templates/path_tmpl.js
@@ -1,11 +1,3 @@
-// TODO: This file was created by bulk-decaffeinate.
-// Sanity-check the conversion and remove this comment.
-/*
- * decaffeinate suggestions:
- * DS102: Remove unnecessary code created because of implicit returns
- * Full docs: https://github.com/decaffeinate/decaffeinate/blob/main/docs/suggestions.md
- */
-
 app.templates.path = function (doc, type, entry) {
   const arrow = '<svg class="_path-arrow"><use xlink:href="#icon-dir"/></svg>';
   let html = `<a href="${doc.fullPath()}" class="_path-item _icon-${
diff --git a/assets/javascripts/templates/sidebar_tmpl.js b/assets/javascripts/templates/sidebar_tmpl.js
index d1d88675..80db6aef 100644
--- a/assets/javascripts/templates/sidebar_tmpl.js
+++ b/assets/javascripts/templates/sidebar_tmpl.js
@@ -1,11 +1,3 @@
-// TODO: This file was created by bulk-decaffeinate.
-// Sanity-check the conversion and remove this comment.
-/*
- * decaffeinate suggestions:
- * DS102: Remove unnecessary code created because of implicit returns
- * DS207: Consider shorter variations of null checks
- * Full docs: https://github.com/decaffeinate/decaffeinate/blob/main/docs/suggestions.md
- */
 const { templates } = app;
 
 const arrow = '<svg class="_list-arrow"><use xlink:href="#icon-dir"/></svg>';
diff --git a/assets/javascripts/templates/tip_tmpl.js b/assets/javascripts/templates/tip_tmpl.js
index db65d32c..223ffe95 100644
--- a/assets/javascripts/templates/tip_tmpl.js
+++ b/assets/javascripts/templates/tip_tmpl.js
@@ -1,10 +1,3 @@
-// TODO: This file was created by bulk-decaffeinate.
-// Sanity-check the conversion and remove this comment.
-/*
- * decaffeinate suggestions:
- * DS102: Remove unnecessary code created because of implicit returns
- * Full docs: https://github.com/decaffeinate/decaffeinate/blob/main/docs/suggestions.md
- */
 app.templates.tipKeyNav = () => `\
 <p class="_notif-text">
   <strong>ProTip</strong>
diff --git a/assets/javascripts/views/content/static_page.js b/assets/javascripts/views/content/static_page.js
index 48e911bd..bdada2e1 100644
--- a/assets/javascripts/views/content/static_page.js
+++ b/assets/javascripts/views/content/static_page.js
@@ -1,11 +1,3 @@
-// TODO: This file was created by bulk-decaffeinate.
-// Sanity-check the conversion and remove this comment.
-/*
- * decaffeinate suggestions:
- * DS102: Remove unnecessary code created because of implicit returns
- * DS206: Consider reworking classes to avoid initClass
- * Full docs: https://github.com/decaffeinate/decaffeinate/blob/main/docs/suggestions.md
- */
 app.views.StaticPage = class StaticPage extends app.View {
   static className = "_static";