From 18b772f3111bb83693c7908fdff2f02d1d0d8275 Mon Sep 17 00:00:00 2001 From: Thibaut Date: Sun, 28 Dec 2014 13:38:49 -0500 Subject: [PATCH] String#remove! returns self in Rails 4.2 --- lib/docs/filters/core/clean_text.rb | 2 +- lib/docs/filters/node/entries.rb | 2 +- lib/docs/filters/postgresql/entries.rb | 2 +- lib/docs/filters/rdoc/entries.rb | 2 +- lib/docs/filters/xpath/entries.rb | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/lib/docs/filters/core/clean_text.rb b/lib/docs/filters/core/clean_text.rb index 851246bc..e525c8a5 100644 --- a/lib/docs/filters/core/clean_text.rb +++ b/lib/docs/filters/core/clean_text.rb @@ -4,7 +4,7 @@ module Docs def call html.strip! - while html.remove!(EMPTY_NODES_RGX); end + while html.gsub!(EMPTY_NODES_RGX, ''); end html end end diff --git a/lib/docs/filters/node/entries.rb b/lib/docs/filters/node/entries.rb index e3b0611c..a7f254a5 100644 --- a/lib/docs/filters/node/entries.rb +++ b/lib/docs/filters/node/entries.rb @@ -54,7 +54,7 @@ module Docs end # Classes - if name.remove! 'Class: ' + if name.gsub! 'Class: ', '' name.remove! 'events.' # EventEmitter klass = name entries << [name, node['id']] diff --git a/lib/docs/filters/postgresql/entries.rb b/lib/docs/filters/postgresql/entries.rb index 583f1075..b8904484 100644 --- a/lib/docs/filters/postgresql/entries.rb +++ b/lib/docs/filters/postgresql/entries.rb @@ -129,7 +129,7 @@ module Docs end def additional_entry_prefix - type.dup.remove!('Functions: ') || self.name + type.dup.gsub!('Functions: ', '') || self.name end def skip_additional_entries? diff --git a/lib/docs/filters/rdoc/entries.rb b/lib/docs/filters/rdoc/entries.rb index 3bceda0b..f20e21ea 100644 --- a/lib/docs/filters/rdoc/entries.rb +++ b/lib/docs/filters/rdoc/entries.rb @@ -11,7 +11,7 @@ module Docs def get_type type = name.dup - unless type.remove! %r{::.*\z} + unless type.gsub! %r{::.*\z}, '' parent = at_css('.meta-parent').try(:content).to_s return 'Errors' if type.end_with?('Error') || parent.end_with?('Error') || parent.end_with?('Exception') end diff --git a/lib/docs/filters/xpath/entries.rb b/lib/docs/filters/xpath/entries.rb index 62728b63..d07f2f86 100644 --- a/lib/docs/filters/xpath/entries.rb +++ b/lib/docs/filters/xpath/entries.rb @@ -4,7 +4,7 @@ module Docs def get_name name = super name.remove!('Axes.') - name << '()' if name.remove!('Functions.') + name << '()' if name.gsub!('Functions.', '') name end